-
Notifications
You must be signed in to change notification settings - Fork 111
Crop screen fixes #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
veejayts
wants to merge
157
commits into
master
Choose a base branch
from
crop_screen_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Crop screen fixes #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get image data into cubit - create, reorder
- get image data into cubit - create, reorder
- get image data into cubit - create, reorder
… auto detect is pressed
…n pubspec.lock - Changed route names in AppRouter to follow Dart naming conventions (e.g., from uppercase to lowercase). - Improved camera initialization in main.dart and added debug prints for available cameras. - Updated system UI configuration in OpenScan widget. - Enhanced theme definition in appTheme.dart by making colors constant. - Updated pubspec.lock with new package versions for various dependencies. - Added a basic widget test for the OpenScan app.
…e UI elements - Updated various package versions in pubspec.lock for better compatibility and performance. - Refactored image cropping logic to handle null results and added error handling for crop failures. - Enhanced UI feedback by displaying error messages when cropping fails. - Improved the polygon painter to ensure proper rendering of crop points and connecting lines. - Adjusted app routing to include a new camera screen and updated theme colors for consistency.
- Added a copyWith method to the ImageOS model for easier state management. - Refactored PreviewScreenBottomBar to a StatefulWidget for improved state handling during image rotation. - Implemented image rotation functionality with database updates and file management. - Improved image display in the home screen with rounded corners for better aesthetics. - Updated .gitignore to exclude build artifacts from the Android app.
- Increased pickup distance for point selection from 40 to 80 for better usability. - Changed toast message from "Document not detected" to "No document detected" for clarity. - Refactored point detection logic to ensure proper handling of small detected areas. - Enhanced debug prints for better tracking of point movements and initialization status.
- Updated PreviewScreenBottomBar to use LayoutBuilder for better responsiveness. - Improved BottomButton styling and layout for a more consistent UI. - Enhanced image zoom functionality in PreviewScreen with better state management. - Refactored ImageCard to use const constructors for performance optimization. - Simplified interaction handling in CropScreenState for improved clarity and maintainability.
- Refactored getImageData method in DirectoryCubit to include error handling and emit loading states. - Improved image loading in ImageCard with FutureBuilder for better user feedback during loading. - Updated crop screen to handle context availability more robustly, ensuring proper rendering of images. - Enhanced UI responsiveness in PreviewScreen and BottomButton components for a smoother user experience.
- Updated OpenCV parameters for improved edge detection and document enhancement. - Introduced new methods for image preprocessing and document corner detection. - Enhanced error handling and logging for better debugging during document detection. - Improved user feedback with detailed logs during image processing and detection. - Refactored crop screen state management for better clarity and maintainability.
- Added enhanceDocument method in ImageUtil for various image enhancement filters. - Updated MainActivity to handle enhanceDocument method calls from Flutter. - Introduced error handling and logging for document enhancement processes. - Refactored method handling in MainActivity for improved clarity and maintainability. - Enhanced NativeAndroidUtil to include initialization checks for method channel.
- Added support for the "original" filter in ImageUtil to clone the source image. - Introduced DocumentFilterType enum for better filter management in the document scanner service. - Updated ImageOS model to include filterType for tracking applied filters. - Enhanced DirectoryCubit with a method to update image filters and manage file operations. - Modified FilterScreen to set the default filter to "original" and improved UI interactions for filter selection. - Improved error handling and loading indicators in various screens for better user experience.
- Updated the layout of the bottom navigation bar to include a page indicator for better user feedback. - Improved state management for page navigation and image cropping actions. - Enhanced the filter button functionality to ensure proper visibility and interaction. - Refactored code for clarity and maintainability, ensuring a smoother user experience.
- Simplified the onPressed callback in ImageCard by using an if-else structure for better clarity. - Enhanced maintainability of the code by reducing nested function calls.
… image handling - Introduced ImageProcessingService to handle image processing tasks in isolates, improving performance and responsiveness. - Added ImageProcessMessage model to encapsulate image processing parameters. - Updated DirectoryCubit to process multiple images concurrently, enhancing user experience during image uploads. - Implemented error handling for image processing failures and provided user feedback through snack bars. - Cleaned up temporary files after processing to optimize storage usage.
…nt and loading indicators - Refactored DirectoryCubit to utilize a copyWith method for better state immutability and clarity. - Introduced an isLoading property in DirectoryState to manage loading states during image processing. - Updated createDirectory and getImageData methods to emit loading states appropriately. - Enhanced the view screen to display a loading overlay while images are being processed, improving user experience. - Improved error handling and user feedback during image processing tasks.
- Updated getImageData method to specify return type for better type safety. - Introduced sharePdf method in FileOperations to handle PDF sharing with a loading dialog. - Refactored FAB widget to improve code readability and maintainability. - Removed unused loading widget to streamline the codebase. - Updated home screen to utilize the new sharePdf method for sharing documents, enhancing user experience.
- Changed the layout of the home screen from a Column to a Row for better alignment of elements. - Enhanced the display of directory information with updated text styles and padding. - Streamlined the sharing and downloading functionality with improved button layouts and snack bar feedback. - Maintained existing functionality while improving code readability and maintainability.
- Introduced selection mode in DirectoryCubit with enableSelection and disableSelection methods for better user interaction. - Refactored selectImage and selectAllImages methods to update image selection state more efficiently. - Added getSelectedCount and getSelectedImages methods to retrieve selected images. - Updated ViewScreen to utilize the new selection state, improving the user experience during image selection. - Enhanced MainBottomSheet to conditionally display selection options based on the selection state.
…proved image handling - Added postScanImageProcessing method in ImageUtil to handle image rotation and saving after scanning. - Updated MainActivity to include a new method for handling post-scan image processing calls from Flutter. - Refactored image rotation logic to utilize the new method in ImageUtil, enhancing code reusability. - Modified DirectoryCubit to streamline image import from the gallery and improve state management during image processing. - Enhanced error handling and user feedback for image processing tasks, improving overall user experience.
…DirectoryCubit - Deleted the ImageProcessingService to streamline image processing functionality. - Integrated image processing directly into DirectoryCubit, enhancing code clarity and maintainability. - Updated the image import process to handle images sequentially, improving error handling and user feedback. - Simplified the logic for processing and saving images, ensuring a more cohesive approach to image management.
- folder size on card - folder naming convention - db deduplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.